Skip to content

Conversation

@joragua
Copy link
Collaborator

@joragua joragua commented Jan 8, 2026

Related Issues

App: #4742

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Jan 8, 2026
@joragua joragua linked an issue Jan 8, 2026 that may be closed by this pull request
@joragua joragua marked this pull request as ready for review January 8, 2026 13:03
@joragua joragua requested a review from jesmrec January 8, 2026 13:03
@joragua joragua force-pushed the fix/edit_space_without_connection branch from afa287f to 382a754 Compare January 8, 2026 13:15
@joragua joragua requested a review from jesmrec January 8, 2026 13:23
@jesmrec
Copy link
Collaborator

jesmrec commented Jan 9, 2026

Two different scenarios here:

  • Connection is already lost when Spaces is clicked -> works fine ✅
  • Connection is up when Spaces is clicked and then, it is lost -> Edit space and Disable space are listed ❌

Steps:

  1. Enter in oCIS account with spaces
  2. Click on Spaces
  3. Remove device connection
  4. Click on ... of any space with permissions of editing

Current:
Edit space and Disable space are listed

Xiaomi Redmi 13, Android 15
809bf710

@joragua
Copy link
Collaborator Author

joragua commented Jan 12, 2026

The second scenario should be fixed with the last commit @jesmrec

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 12, 2026

The second scenario should be fixed with the last commit @jesmrec

Fixed. I realised a side-effect: with the new request, when the ... is clicked without connection, the FAB gets also hidden ✅ , but, does not get visible if the connection is recovered ❌ . I mean, everything inside the Spaces view, browsing through views makes everything perfect.

Is it posible to check it when the view is refreshed? does it make sense? @joragua

@joragua
Copy link
Collaborator Author

joragua commented Jan 12, 2026

The view (in this case, the FAB) is refreshed when the three-dot menu button is opened, or when you navigate to another screen and then return to the spaces list.

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 12, 2026

The view (in this case, the FAB) is refreshed when the three-dot menu button is opened, or when you navigate to another screen and then return to the spaces list.

Let's get this as a good approach.

Approved, moving forward!

@joragua joragua force-pushed the fix/edit_space_without_connection branch from db45923 to 2fb2898 Compare January 12, 2026 13:05
@joragua joragua merged commit 5027e36 into master Jan 12, 2026
10 checks passed
@joragua joragua deleted the fix/edit_space_without_connection branch January 12, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Edit space option available with no connection

4 participants